Fix caching error when offline and no refs dir #1307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will not fix the root issue of #1305 but fixes the non-explicit
FileNotFoundErrorthat was raised (in favor of the documented and expectedLocalEntryNotFoundError).cc @NielsRogge for some reason downloading a file in your space failed due to a connection issue (infra issue ?
HF_HUB_OFFLINEset ?). Instead of the properLocalEntryNotFoundError(that is handled nicely intransformers) you had aFlieNotFoundErrorbecause the cache in your space was not initialized yet. This also explains why it's working locally on your computer (since I guess cache structure is already good). This PR should fix it.